•

isBooleanTooLongAndComplex

https://testing.googleblog.com/2024/04/isbooleantoolongandcomplex.html

This is another post in our Code Health series. A version of this post originally appeared in Google bathrooms worldwide as a Google Tes...

Short but honestly good advise to rather pull boolean checks apart and re-group them as they make sense in the context of the given situation you're checking for.

I started doing this when building an alert-check system for the company I'm working for right now, and it really helps organize what is a pre-condition, what a syntactical requirement, etc etc.

23 comments

See all comments

robinm

•

I absolutely agree that method extraction can be abused. One should not forget that locality is important. Functionnal idioms do help to minimise the layer of intermediate functions. Lamda/closure helps too by having the function much closer to its use site. And local variables can sometime be a better choice than having a function that return just an expression.